Date: Wed, 12 Nov 2014 20:42:59 +0100 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: [PATCH] OpenBSD disk encryption On 2014-11-12 08:39, Thiébaud Weksteen wrote: > Hi guys, > > I wrote a patch for bleeding-jumbo to handle OpenBSD disk encryption . > I've also added a python script to extract the necessary values from a > disk image. > > Before I submit a pull request to GitHub, I'd like your comments on it. Thanks! I'll accept it as-is but there seem to be room for improvement: For example, we have shared functions for PBKDF2-SHA1 using SSE2 and with some other optimizations, it may be 3-8 times faster (see pbkdf2-hmac-sha1_fmt_plug.c for example use). Also, just from a very quick look it appears to me you could use a normal binary instead of treating it as a "non-hash" but I may be wrong. And that will probably not matter unless you try to crack lots of hashes at once, which is probably not the normal use case. magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.