Date: Thu, 14 Nov 2013 15:51:15 +0100 From: Lukas Odzioba <lukas.odzioba@...il.com> To: john-dev@...ts.openwall.com Subject: Re: Fix broken formats (#420) 2013/11/14 Frank Dittrich <frank_dittrich@...mail.com>: > Dosn't your looks_like_nice_int() treat empty strings as valid integer > representations? Yes, I know plus it segfaults on NULL arg. > Is that intended? I think it is not a problem in the current code. I had if(p&&*p) check at the begin of this function, but I removed it since it's not used anywhere else. After all it might be a good idea to put it back, before someone copy-paste it. Lukas
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.