[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Tue, 1 Oct 2013 13:25:01 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: rakp format
magnum,
The CPU rakp format segfaults during self-test for me, at least in an
linux-x86-64-avx build without OpenMP. The segfault occurs inside the
first one of these free() calls from formats.c: fmt_self_test():
MEM_FREE(salt_alloc);
MEM_FREE(binary_alloc);
Commenting both of them out results in a self-test failure reported for
crypt_all(), which means that it returns other than the expected value.
This suggests that crypt_all() itself causes memory corruption (both
heap and stack at once? would be weird).
I guess you're the one to fix this.
Additionally, both rakp and rakp-opencl process the salt for each
candidate password individually (unless the OpenCL compiler manages to
optimize that, which it might). I think a SHA-1 computation may be
moved from crypt_all() into set_salt().
Thanks,
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
