Date: Thu, 26 Sep 2013 04:30:03 +0400 From: Solar Designer <solar@...nwall.com> To: john-dev@...ts.openwall.com Subject: Re: wordlist.c artefacts magnum - On Thu, Sep 26, 2013 at 12:35:52AM +0200, magnum wrote: > This hunk came with 220.127.116.11-c6, made it into bleeding-jumbo's wordlist.c > when I merged core fork/node and still remain there: > > @@ -378,6 +377,9 @@ void do_wordlist_crack(struct db_main *db, char > *name, int rules) > trash the buffer. It's also disabled by --save-mem=N */ > ourshare = (file_len / options.node_count) * > (options.node_max - options.node_min + 1); > + if (options.node_count >= 1000000000) > + ourshare = 0; > + if (options.node_count != 1000000000) > if (!(options.flags & FLG_EXTERNAL_CHK) && > !mem_saving_level) > if ((options.node_count > 1 && > file_len > options.node_count * (length * 100) && Yeah, I had noticed this, but did not bother to notify you. > What are those 1G tests for? Some kind of debugging? They're a hack I used along with my Perl scripts in CMIYC 2011 and 2012 (if I recall correctly). They were never meant to get into a released jumbo. They're most likely broken (not usable for their original purpose, which no one but me was even aware of) when blindly merged into the released reimplementation of the --node feature. > I should remove them, right? Yes. Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.