Date: Thu, 5 Sep 2013 00:17:28 +0530 From: Sayantan Datta <std2048@...il.com> To: john-dev@...ts.openwall.com Subject: Re: mask mode bug (was: Sayantan's Weekly Report #12) On Wed, Sep 4, 2013 at 7:47 AM, Sayantan Datta <std2048@...il.com> wrote: > > On Wed, Sep 4, 2013 at 3:33 AM, magnum <john.magnum@...hmail.com> wrote: > >> The enclosed patch seems to do the trick. I see another problem too: With >> 8-bit masks, eg. [\x20-\xff] (you need to escape or quote the backslashes >> in the shell unless adding it as ?A in rpp.c), it cracks hashes but you get >> false result from get_key (the worst bug next to false negatives!). The >> first character is garbage. Possibly a signed char problem? It works fine >> with CPU formats. >> >> Also, I really dislike that you pin LWS to 64 in mask mode but maybe >> that's hard to work around. >> >> Am I interfering with GSoC now? Just tell me to shut up :) It's so cool >> doing 250 Mp/s on a laptop, I can't stop myself. >> > > No, of course not. I was a little busy for last few days and didn't had > much time to reply to the posts in daytime. Suggestions are always > appreciated. I'll check the patch at night and apply it. > > Regards, > Sayantan > Yes, it was a bug indeed. I have applied this fix to other formats too with some minor modifications. Thank you. BTW what is the best way to find these type of bugs other than experience? Regards, Sayantan Content of type "text/html" skipped
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.