Date: Tue, 3 Sep 2013 17:14:58 +0200 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: mask mode bug (was: Sayantan's Weekly Report #12) On 3 Sep, 2013, at 3:49 , Sayantan Datta <std2048@...il.com> wrote: > Priorities: > - Find more bugs and try to fix them. I think I found a main reason for segfaults. I only looked at raw-md5 but it might be in all/some of the others too: When you allocate pinned_partial_hashes and map partial_hashes, you allocate as "4 * kpc" (where kpc is synonym with GWS) while I believe it's supposed to be "multiplier * 4 * kpc" or perhaps rather "loaded_count * 4". I haven't fully digested the new code so I'm not sure which but it's definitely allocated too small now. This is easily triggered when using a low GWS and a high number of loaded hashes. cheers, magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.