Date: Sun, 1 Sep 2013 15:25:52 +0200 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: new format parameter patch for bleeding-jumbo On 1 Sep, 2013, at 15:14 , Sayantan Datta <std2048@...il.com> wrote: >> On Sun, Sep 1, 2013 at 5:09 PM, magnum <john.magnum@...hmail.com> wrote: >> I think we should stop and think for a minute first. Why not just use a global variable instead? All formats initially set this to zero, even your mask-enabled ones - so what good does this in the format struct? > > Yes, for now it does nothing. But I will post a patch for bleeding-mask that will do initial processing of mask during format initialization, at least that is the plan. This will help us in future to write a self test for mask mode. Also I think initial processing of mask should be done during format initialization, not before cracking. OK. So maybe it should initially tell the maximum figure that may be used, and after init/reset it will tell the actual figure for this run? That would probably help fixing https://github.com/magnumripper/JohnTheRipper/issues/328 too. I'll apply it now. magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.