[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <8edb885d2f32eeb99d212ffb0b81df01@smtp.hushmail.com>
Date: Thu, 8 Aug 2013 20:59:59 +0200
From: magnum <john.magnum@...hmail.com>
To: "john-dev@...ts.openwall.com" <john-dev@...ts.openwall.com>
Subject: Self-test-specific code defeats the whole idea of self-test
Sayantan,
Apparently you have added specific get_key_self_test() and crypt_all_self_test() functions in four OpenCL formats and they even have self-test specific kernels. If we go that path, we can just as well drop the whole idea of self-tests, no? It is totally OK in an experimental branch but hacks like that does not belong in bleeding at all IMHO, other than for very short time if you have a specific plan (but that should ideally evolve in a topic branch). In my book this is four release blockers.
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
