Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 30 May 2013 01:01:07 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: Unify internal form of mscash2 hashes?

On 28 May, 2013, at 10:18 , Sayantan Datta <std2048@...il.com> wrote:
> Hi ,
> On Tue, May 28, 2013 at 12:51 PM, magnum <john.magnum@...hmail.com> wrote:
> Sayantan, will you have a look at this please? I think you merely need to take prepare() as-is from the CPU format.
> 
> Cool, no problem. 

Yet you wrote your own again? I suggest you use the well tested valid(), split() and prepare() from the CPU format. There is really no need to invent worse wheels. I can crash your latest version like this:

$ echo aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > test
$ ../run/john -form:mscash2-opencl test
Segmentation fault: 11

If I replace those three functions with the CPU versions, problem goes away.

magnum

Powered by blists - more mailing lists

Your e-mail address:

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.