Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 06 May 2013 05:34:36 +0400
From: Alexander Cherepanov <cherepan@...me.ru>
To: john-dev@...ts.openwall.com
Subject: Re: Core: build warning

Solar, Jim,

On 2013-05-06 04:47, Solar Designer wrote:
>> inc.c: In function ?do_incremental_crack?:
>> inc.c:478: warning: comparison is always false due to limited range of data type
>
> Yes, I had expected that we'd get this sort of warnings, and I was
> surprised I was not getting any of them.  I still don't know why not.
> For me, gcc silently omits the "offending" check from generated code.

Solar, some other warnings (from -std=c89 -pedantic) you could be 
interested in:

options.c: In function ‘print_usage’:
options.c:115: warning: string length ‘1463’ is greater than the length 
‘509’ ISO C90 compilers are required to support
options.c:117: warning: string length ‘1463’ is greater than the length 
‘509’ ISO C90 compilers are required to support
options.c:117: warning: string length ‘1463’ is greater than the length 
‘509’ ISO C90 compilers are required to support
status.c: In function ‘status_print_cracking’:
status.c:202: warning: initializer element is not computable at load time
trip_fmt.c: In function ‘get_hash_0’:
trip_fmt.c:265: warning: ISO C90 forbids mixed declarations and code
trip_fmt.c: In function ‘get_hash_1’:
trip_fmt.c:266: warning: ISO C90 forbids mixed declarations and code
trip_fmt.c: In function ‘get_hash_2’:
trip_fmt.c:267: warning: ISO C90 forbids mixed declarations and code
trip_fmt.c: In function ‘get_hash_3’:
trip_fmt.c:268: warning: ISO C90 forbids mixed declarations and code
trip_fmt.c: In function ‘get_hash_4’:
trip_fmt.c:269: warning: ISO C90 forbids mixed declarations and code
trip_fmt.c: In function ‘get_hash_5’:
trip_fmt.c:270: warning: ISO C90 forbids mixed declarations and code
trip_fmt.c: In function ‘get_hash_6’:
trip_fmt.c:271: warning: ISO C90 forbids mixed declarations and code
trip_fmt.c: In function ‘cmp_one’:
trip_fmt.c:512: warning: ISO C90 forbids mixed declarations and code
trip_fmt.c: In function ‘cmp_exact’:
trip_fmt.c:520: warning: ISO C90 forbids mixed declarations and code

Jim, BTW what do you do with compiler.c when you compile in MS Visual 
Studio? AFAIK it doesn't support computed gotos. Do you convert it to 
switch?

-- 
Alexander Cherepanov

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.