Date: Sun, 5 May 2013 23:37:55 +0200 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: SSE code in pbkdf2_hmac_sha1 and pbkdf2_hmac_sha256 code Committed. magnum On 5 May, 2013, at 23:19 , jfoug <jfoug@....net> wrote: > Here is the fix for encfs for non-SSE. > > Simple fix ;) The code was still using the older function name. The extra param had been added, but I had never compiled it. The extra param says to get data starting from offset 0. But the name of the function was also changed from pbkdf2() to pbkdf2_sha1(), and my original edits had not done that. > > Jim. > > -----Original Message----- > From: jfoug@....net [mailto:jfoug@....net] > Sent: Sunday, May 05, 2013 15:58 > To: john-dev@...ts.openwall.com > Cc: Dhiru Kholia > Subject: Re: [john-dev] SSE code in pbkdf2_hmac_sha1 and pbkdf2_hmac_sha256 code > > Magnum found a problem building encfs without SSE. That was a late change for me. it was not on my list of ones todo, and has actually been removed from my build tree since last August (had serious portability issues with VC). I found it when pulling a clean git tree on x64, patching it, and building. But I think only the sse part (that I added), got properly tested. The non-sse was still in older format. I will get that fixed soon. > > Jim. > > ---- Dhiru Kholia <dhiru.kholia@...il.com> wrote: >> On 05/05/13 at 11:39am, jfoug@....net wrote: >>> I have modified both of these headers. They now build with either >>> oSSL code, or with SSE intrinsic code, depending upon the build >>> target. >>> On my PC, zip went from 650 to about 1500 with the original change. >>> Then to about 3100 after my changes, (oSSL build), and about 9k for >>> SSE2 builds. So from 650 to 9k is not a bad speedup ;) >> >> Great work Jim :-) >> >> -- >> Dhiru > <JtR-bleeding-encrfs-any-pbkdf2-fix.patch>
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.