Date: Fri, 3 May 2013 16:49:16 +0200 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: Yet more crashes On 3 May, 2013, at 1:47 , magnum <john.magnum@...hmail.com> wrote: > On 3 May, 2013, at 0:38 , Lukas Odzioba <lukas.odzioba@...il.com> wrote: > >> 2013/5/2 Dhiru Kholia <dhiru.kholia@...il.com>: >>> The following formats still crash, >>> >>> gpg >>> rar >>> zip >>> sip >>> >>> Out of these, gpg and sip should be easy to fix. >> >> I reviewed sip and I think that this small change is pretty much all >> what we need. >> Lukas >> <sip_valid.diff> > > committed to both branches This was b0rken. $ ../run/john --test -form:sip Benchmarking: SIP MD5 [32/64]... FAILED (valid) + if (strspn(ciphertext, "*") != 14) + return 0; This strspn() will return the length of ciphertext, from start of it, that consist of characters within the string "*", ie. none. For eg. "**hel*lo**" it would return 2. I'll revert it. magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.