Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 13 Apr 2013 15:48:41 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: [patch] sse/xop implementation of raw-sha256

On 11 Apr, 2013, at 15:19 , jfoug@....net wrote:
> Since you are still working on this, I would like to ask for these changes:
> 
> 1.  change the wrapper #define.
> 
> Currently  
> #ifdef __SSE2__
> 
> Please change to:
> #include "arch.h"
> #ifdef MMX_COEF

Doesn't this also apply to Tavis' raw-sha1-ng? Also, shouldn't it be

#if MMX_COEF == 4

so it doesn't kick in for an MMX-only build? Not that I think many people get the idea to build john on them.

magnum


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.