Date: Fri, 15 Feb 2013 18:33:47 +0100 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: [PATCH] Add support for WinRAR SFX files On 15 Feb, 2013, at 17:03 , Dhiru Kholia <dhiru.kholia@...il.com> wrote: > On Thu, Feb 14, 2013 at 11:26 PM, magnum <john.magnum@...hmail.com> wrote: >> On 14 Feb, 2013, at 11:33 , Dhiru Kholia <dhiru.kholia@...il.com> wrote: >>> The attached patch adds support for parsing WinRAR SFX files to >>> rar2john utility. Please review. >> >> Could "int diff" be too small for very large archives? Or maybe that size diff is only the size of SFX wrapper. Should be fine then. > > The maximum value of "diff" can be 4096 (CHUNK_SIZE). So using "int" > type for it should be OK. Fine. I guess you can commit it to both branches then! magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.