Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 1 Feb 2013 14:51:54 +0400
From: Solar Designer <>
Subject: Re: NetNTLMv1

magnum -

On Fri, Feb 01, 2013 at 07:24:22AM +0400, Solar Designer wrote:
> Anyhow, I've attached a patch that tries to speedup cmp_all() by use of
> a bitmap.

There's a bug in that patch: the mem_alloc_tiny() call for bitmap
allocation should be changed to mem_calloc_tiny().

I initially had a memset() in crypt_all(), but later #if 0'ed it out in
favor of another approach - but forgot that the bitmap was not zeroized
in init().  This needs to be corrected (as above).


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.