Date: Sun, 27 Jan 2013 23:35:44 +0100 From: magnum <john.magnum@...hmail.com> To: "john-dev@...ts.openwall.com" <john-dev@...ts.openwall.com> Subject: Bug in a number of "crack array" formats Dhiru, You need to revise all formats that use a crack array. I fixed the keyring format in cf3be2d and now I see several others that do the Wrong Thing[tm]. You can't reset the array in set_salt() because if we only have one salt, set_salt() will only be called once and never again. I get a deja-vu now, I am pretty sure we have told you this before. I think you should do this: 1. If using an "any_cracked" variable, reset it in crypt_all() before the OMP loop. 2. Always set *or reset* cracked[index] in crypt_all(). Ie. do not just set it on successfull crack but also reset it otherwise. This way you'll have no problems. This must be fixed before J8. magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.