Date: Sat, 26 Jan 2013 22:11:53 +0100 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: Segfault in Jumbo --stdout On 26 Jan, 2013, at 21:40 , Frank Dittrich <frank_dittrich@...mail.com> wrote: > On 01/26/2013 09:19 PM, magnum wrote: >> On 26 Jan, 2013, at 18:29 , Frank Dittrich <frank_dittrich@...mail.com> wrote: >>> A better fix is: >>> >>> >>> - if (!strncmp(database.format->params.label, "wpapsk", 6) && >>> + if (database.format->params.label && >>> + !strncmp(database.format->params.label, "wpapsk", 6) && >>> >>> >>> But that the segfault didn't occur without --rules indicates that >>> magnum's intended fix do adjust min. length for wpapsk to 8 doesn't >>> always work. >> >> He said without --stdout, not without --rules. So your proposed patch is the Right Fix[tm]. I will apply it. > > Before I wrote the patch, I tried to reproduce the problem. > But my first attempt failed, because I used > $ ./john --wordlist=password.lst --stdout > instead of > $ ./john --rules --wordlist=password.lst --stdout That is strange. The --rules option should have nothing to do with it. magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.