[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 26 Jan 2013 21:19:51 +0100
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: Segfault in Jumbo --stdout
On 26 Jan, 2013, at 18:29 , Frank Dittrich <frank_dittrich@...mail.com> wrote:
> On 01/26/2013 04:02 PM, Dhiru Kholia wrote:
>> On Sat, Jan 26, 2013 at 7:01 PM, Costin Enache <e_costin@...oo.com> wrote:
>>> ./john --rules --wordlist=password.lst --stdout
>>>
>>> Segmentation fault
>>>
>>> Something went wrong. The world list can exist or not, the segfault happens
>>> earlier. Without using –stdout all is fine.
>>
>> Hi Costin,
>>
>> Thanks for the report.
>>
>> Disabling "if (!strncmp(database.format->params.label, "wpapsk", 6)"
>> code-block in john.c (line 726) makes the problem go away.
>>
>> Hopefully someone familiar with this piece of code will take a look soon.
>
> A better fix is:
>
>
> - if (!strncmp(database.format->params.label, "wpapsk", 6) &&
> + if (database.format->params.label &&
> + !strncmp(database.format->params.label, "wpapsk", 6) &&
>
>
> But that the segfault didn't occur without --rules indicates that
> magnum's intended fix do adjust min. length for wpapsk to 8 doesn't
> always work.
He said without --stdout, not without --rules. So your proposed patch is the Right Fix[tm]. I will apply it.
Thanks,
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
