Date: Mon, 21 Jan 2013 18:45:08 +0530 From: Dhiru Kholia <dhiru.kholia@...il.com> To: john-dev@...ts.openwall.com Subject: Re: Unused functions in mozilla_des.c On Mon, Jan 21, 2013 at 5:24 PM, Frank Dittrich <frank_dittrich@...mail.com> wrote: > On 01/17/2013 06:01 PM, Frank Dittrich wrote: >> So, I suggest to follow magnum's suggestion and just remove unused >> functions. (We might need DES_DestroyContext in future versions, though. >> Just in case we have proper cleanup functions in the format definition.) >> >> The attached has #if 0 ... #endif around unused functions in >> mozilla_des.c, and unused functions in mozilla_des.h commented out using >> //, even for DES_DestroyContext, which we might need in future. > > Should I prepare a patch and a pull request, removing all unused > functions from mozilla_des.c (perhaps keeping DES_DestroyContext withing > #if 0 ... #endif, just in case we need it in future john versions? Or is > someone else already working on it? Please go ahead. I am working on something else currently. -- Dhiru
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.