Date: Thu, 17 Jan 2013 13:22:01 +0100 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: NSS not needed (was: old clang warning in mozilla_des.c) On 16 Jan, 2013, at 4:14 , Dhiru Kholia <dhiru.kholia@...il.com> wrote: > On Jan 16, 2013 4:20 AM, "Frank Dittrich" <frank_dittrich@...mail.com> wrote: > > > > clang correctly points out that inLen < 0 is alway false in > > mozilla_des.c line 833, because inLen is unsigned int. > > > > When I searched for users of DES_Encrypt(), I found none. > > > > Removing DES_Encrypt() from mozilla_des.c and mozilla_des.h still allows > > building john, with or without -DHAVE_NSS. > > Yes, the format can be built without NSS. > > I suspected this earlier and now you have confirmed it. > > I will take a look at it soon. Thanks Frank. This would be nice for Jumbo-8, please commit to unstable if you fix it. Remove all references to HAVE_NSS in Makefile too. magnum Content of type "text/html" skipped
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.