Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 13 Jan 2013 21:36:43 +0100
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: Changes to common-opencl.c

On 13 Jan, 2013, at 19:09 , Claudio André <claudioandre.br@...il.com> wrote:

> Em 13-01-2013 15:53, Claudio André escreveu:
>> 
>> Could you please test it latter? You put a lot of specialized information there and i don't have the hardware.
>> 
> 
> Maybe Bull has enough hardware. Anyway, it is suited for wide testing now, so please do it.


Tried it on Bull and on OSX. I think it's starting to look really good already, I tried non-OpenCL formats, OpenCL ones, --test all/single formats and --list=opencl-devices. The latter is OK for now, we might come up with some cosmetical changes later but that is not important at all. Anyway all vendor-specific output seem to work for both nvidia and AMD.

Personally I'd like to change

Using device 0: GeForce GTX 570

to just

Device 0: GeForce GTX 570

but that might not be the most important thing to bother with... On another less important note I think we should add the AMD specific name if available (list-devices shows this), so instead of just

Device 1: Tahiti

it could be

Device 1: Tahiti (AMD Radeon HD 7900 Series)

or perhaps

Device 1: AMD Radeon HD 7900 Series (Tahiti)


For parsing, try to follow how --groups are parsed in options.c and getopt.[ch]. It seems the provided functions can do most things we need. I haven't looked at it now but I'd expect some "documentation" within getopt.h.

magnum

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.