Date: Sun, 13 Jan 2013 12:52:22 -0200 From: Claudio André <claudioandre.br@...il.com> To: john-dev@...ts.openwall.com Subject: Re: Changes to common-opencl.c Em 13-01-2013 00:28, magnum escreveu: > We'll see what Sayantan says but my first reflection is we only need a devices array. We could drop the platform notion everywhere except --list=opencl-devices, which should show the same information as eg. clinfo does, as well as the JtR's device number that matches each "platform:device". I like this too (in the mean time, i removed all use of platform in all formats except, of course, Sayantan's). > >> >Important: >> >- I changed all but Sayantan's formats to this new API (only one line per format). I mean. >> > . we do the 'initialization' of opencl using platform_id and device_id. >> > . but then uses ocl_gpu_id. See the questions above. >> >- I need to understand Sayantan usage of copied common-opencl.c code to change it. Even better, Sayantan can say his opinion on the matter. >> >- magnun's code as listOpenCLdevices was not tested. >> > >> >Patch (only a few formats was tested) >> >https://github.com/claudioandre/JohnTheRipper/commit/bcde5f7ddbc3686a346274d6c6ec5a05183bfdd3 > I'll have a look at it. I'm tempted to include this in Jumbo-8 if we are to change the --platform and --device syntax. The earlier we do such things, the better. Not now, but we can discuss this latter. Your jumbo-8 changes resulted in merge conflits, so attention is really necessary when merging back. Claudio
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.