Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 7 Jan 2013 03:22:34 +0100
From: magnum <>
Subject: Re: Trying to build john without *_fmt_plug.c

The dynamic patch broke generic builds:

$ make -sj8 generic
dynamic_fmt.c: In function ‘clear_keys’:
dynamic_fmt.c:1236: error: ‘total_len’ undeclared (first use in this function)
dynamic_fmt.c:1236: error: (Each undeclared identifier is reported only once
dynamic_fmt.c:1236: error: for each function it appears in.)
make[1]: *** [dynamic_fmt.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [generic] Error 2


On 5 Jan, 2013, at 21:40 , wrote:

> Here are some other changes.
> 1. in formats.c, the 2nd loop in the 'max length' check, should start at 0, not at 1.
> 2. there was a crash that happened due to the max length check, in dynamic.  It ONLY happened on dyna_26, and only on 32 bit, and only if not using SHA_PARA (i.e. is falling back to using the older sha1.S asm code).    The bug was triggered by adding keys in this order:  1, 0, 2, 3.  What happened is the real key was added first (index 1), then the long keys were added, to idx 0, 2, 3.  Well, for this specific 'build' of SHA1 code, there was still a straggler if(index==0) lengths=0   i.e. older code that was before addition of clear_keys() method.
> 3. a change to john.c so that -format=dynamic  again 'works' like it did before the dynamic format was split up from being a single polymorphic format, to a bunch of 'thin' formats.  Now, -format=dyamic will load all dynamic formats (very useful in -testing)
> Jim.
> On Sat, Jan 5, 2013 at 12:20 PM, magnum wrote:
>> On 5 Jan, 2013, at 18:19 , <> wrote:
>>> here is a patch that removes any plug dependencies.  That is if you manually rename NT_fmt_plug.c to NT_fmt.c and gost_plug.c to gost.c. NOTE, I did not look at uaf2john depending upon uaf_encode_plug.c, since I have moved that fully out of my test environment, due to it being 100% not buildable under VC.
>> Thanks, I'll have a look at it soon.
>> magnum
> <JTR-Dynamic_Fixes_ST_and_dynamic_fmt_name.diff>

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.