Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 15 Dec 2012 19:33:38 +0100
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: bash completion failures

On 15 Dec, 2012, at 13:44 , Frank Dittrich <frank_dittrich@...mail.com> wrote:
> On 12/15/2012 01:20 PM, magnum wrote:
>> No hidden options work, other things work correctly. If I just write "../run/john --[tab][tab]" I also get a list lacking the hiddens.
> 
> Now I am able to reproduce.
> 
> I always started john from the run directory and used ./john.
> If I move to the src directory and use ../run/john, completion for
> hidden options doesn't work.
> 
> Now I found the culprit in line 142 of the script.
> Here I concatenate the options from the regular usage output and the
> output of --list=hidden-options.
> But instead of the name that is used to invoke john, I use "./john" for
> --list=hidden-options.
> This needs to be replaced by  ${first}
> Otherwise completion only works as long as you are in the run directory
> and as long as the binary is called john.
> 
> Feel free to correct this or wait until I submit a patch.

Great, I'll fix it.

Thanks,
magnum

Powered by blists - more mailing lists

Your e-mail address:

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.