[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 10 Dec 2012 12:59:19 +0530
From: Dhiru Kholia <dhiru.kholia@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: fixing the valid() methods
On Mon, Dec 10, 2012 at 12:27 PM, magnum <john.magnum@...hmail.com> wrote:
> On 10 Dec, 2012, at 7:39 , magnum <john.magnum@...hmail.com> wrote:
>> On 10 Dec, 2012, at 4:13 , Dhiru Kholia <dhiru.kholia@...il.com> wrote:
>>> + if (strncmp(ciphertext, "$racf$*", 7))
>>> + goto err;
>>>
>>> I do that already. Is the code above good enough?
>>
> Is RACF really case significant? The test vectors are all uppercase. Maybe the format should not have FMT_CASE but instead uppercase its input in set_key()? It might not even be FMT_8_BIT for that matter. If it is, such uppercasing should be made encoding aware (just use enc_strupper() from unicode.h).
I have seen mainframes using mixed-case passwords (I will get some
test vectors soon hopefully), so FMT_CASE is needed. Not sure about
FMT_8_BIT.
--
Cheers,
Dhiru
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
