[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 8 Sep 2012 14:47:21 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: New formats: KRB5-18 and KRB5-23
That looks correct to me. Is there something similar in krb5-23?
I tried this on OSX and now got this:
Benchmarking: KRB5 aes256-cts-hmac-sha1-96 [32/64]...
Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: 13 at address: 0x0000000000000000
0x00000001000408ac in crypt_all (count=98745856) at krb5-18_fmt.c:198
198 crypt_out[index][i] = (key.contents[4 * i]) |
(gdb) bt
#0 0x00000001000408ac in crypt_all (count=98745856) at krb5-18_fmt.c:198
#1 0x0000000100099b46 in fmt_self_test (format=0x1002dff20) at formats.c:104
Previous frame inner to this frame (gdb could not unwind past this frame)
This is a non-OMP build. Note the count=98745856... I'm puzzled this only happens on OSX.
magnum
On 8 Sep, 2012, at 14:03 , Dhiru Kholia <dhiru.kholia@...il.com> wrote:
> On Sat, Sep 8, 2012 at 4:30 PM, magnum <john.magnum@...hmail.com> wrote:
>> On 7 Sep, 2012, at 20:30 , Camille Mougey <commial@...il.com> wrote:
>> It fails on Linux too when built with OMP. One of the formats (can't remember which now) stopped failing with OMP_NUM_THREADS=1, the other failed anyway.
>
> The following patch fixes the Linux OMP problem.
>
> diff --git a/src/krb5-18_fmt.c b/src/krb5-18_fmt.c
> index cff6e3e..e0adf04 100644
> --- a/src/krb5-18_fmt.c
> +++ b/src/krb5-18_fmt.c
> @@ -68,9 +68,6 @@ static char (*saved_key)[PLAINTEXT_LENGTH + 1];
> static char saved_salt[SALT_SIZE];
> static ARCH_WORD_32 (*crypt_out)[16];
>
> -static krb5_error_code ret;
> -static krb5_data string;
> -static krb5_keyblock key;
> static krb5_data salt;
> static krb5_enctype enctype;
>
> @@ -184,7 +181,9 @@ static void crypt_all(int count)
> for (index = 0; index < count; index++)
> #endif
> {
> -
> + krb5_data string;
> + krb5_error_code ret;
> + krb5_keyblock key;
> salt.data = saved_salt;
> salt.length = strlen(salt.data);
> string.data = saved_key[index];
>
>
> Does it look okay to you? I will commit this to magnum-jumbo once I
> get positive feedback.
>
> --
> Cheers,
> Dhiru
>
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
