Date: Tue, 21 Aug 2012 16:54:53 +0400 From: Aleksey Cherepanov <aleksey.4erepanov@...il.com> To: john-dev@...ts.openwall.com Subject: Re: Aleksey's daily status report #13 On Mon, Aug 20, 2012 at 07:48:30PM +0400, Alexander Cherepanov wrote: > On 20.08.2012 03:14, Aleksey Cherepanov wrote: > >- All packages are on the wiki. > >http://openwall.info/wiki/john/johnny > > A couple of remarks: > > 1. When I tried to load nt hashes (hashes-7.nt.txt for the last > contest) johnny selected lm hashes which is no surprise because john > core doesn't support nt. But after I start attack johnny becomes > unresponsive and I need to kill it. Problem is that there 15k of the same hashes. So when johnny calls `john -show` it gets 15k of pairs nothing:doubleemptylmhash, then for each pair it goes over 15k rows in the table and writes empty string (password) there. So we get 15k*15k = 225M table operations, it is just slow. I fixed that. Now hashes are removed from table index after first filling. So password is written only once (to all rows with respective hash). I see its implication onto case when 1 hash could have 2 different passwords. In any case it would not work as it was before. It is a problem for the future. > 2. Now johnny show a warning about default path to john when starting. > IMHO it's better to remove it (or move it to Settings dialog or > somewhere) because it's 1) more-or-less evident and 2) annoying. It is not always obvious. But for package users it should natural. I removed message on start-up. Frank, are you ok with such change? Then I'd like to add something like message on every john invocation indicating that default settings is used (of course with checkbox "do not show this again" available). > And it needs a reformulation to improve its English. Quick patch: > > diff --git a/mainwindow.cpp b/mainwindow.cpp > index 0a45ec9..f9a8f5f 100644 > --- a/mainwindow.cpp > +++ b/mainwindow.cpp > @@ -951,8 +951,8 @@ void MainWindow::warnAboutDefaultPathToJohn() > tr("Johnny: default path to john"), > tr("Currently Johnny filled settings with default path to John the Ripper (%1). " > "You could set your preferred path in settings " > - "(use just 'john' there to make Johnny to search John " > - "on PATH before every start of John). " > + "(just use 'john' there to make Johnny search John " > + "in PATH on every invocation of John). " > "If you are satisfied with defaults then save settings to avoid this message.").arg( > m_ui->comboBox_PathToJohn->currentText())); > } I replaced "John" with "John the Ripper" in both modified strings. Changes were pushed. Currently I am going to rebuild, repackage and retest everything. Thanks! -- Regards, Aleksey Cherepanov
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.