Date: Sun, 15 Jul 2012 19:03:29 +0200 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: My audit of cracker, format, loader.c On 2012-07-15 18:27, jfoug wrote: > Cracker.c: All changes appear good. > > > > Format.c: > > - force un-aligned input to salt removed, but this may have been by design. > > - the overflow logic of salt and binary buffers was lost in fmt_self_test() Both these were Jumbo only (by me) and with the not-yet-merged core changes I believe the extra alignment stuff is not needed at all. The overflow "canary" logic has never caught one single bug so I though it's better to stay close to core. > Loader.c > > - Nightmare diff. I will have to look at that, when I have more time, and a > clear head. But I think there is differences between what used to be in > jumbo, and now, logic wise. Possibly things that were busted before in > jumbo are fixed, I do not know. But obviously changes, as shown by the > prior 2 issues I found there. When you diff that one to core code, it's simpler to see. Code differs much less from core now. magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.