Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 13 Jul 2012 12:07:59 +0200
From: Frank Dittrich <frank_dittrich@...mail.com>
To: john-dev@...ts.openwall.com
Subject: Re: RACF format

On 07/13/2012 11:46 AM, Solar Designer wrote:
> On Fri, Jul 13, 2012 at 03:06:06PM +0530, Dhiru Kholia wrote:
>> On Fri, Jul 13, 2012 at 2:26 PM, Solar Designer <solar@...nwall.com> wrote:
>>> racf_fmt_plug.c needs a proper valid(), not just a check for $racf$.
>>
>> This problems exists in lot of my formats. I am secretly waiting for
>> Frank to send the patches ;)
> 
> Don't wait.  Patch.

Right. I am too busy with other things.
If I had time, I would prefer to add new/enhanced functionality.

One other format which still needs an improved valid() is episerver
(looks like the inappropriate name will stay).
episerver_fmt.c's valid() also just contains
return !strncmp(ciphertext, "$episerver$", 11);

Almost everything you find using

grep -C 2 "return\s*\!strncmp(ciphertext" *.c

(except dynamic_fmt.c) needs to be fixed


Frank

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.