Date: Thu, 05 Jul 2012 23:40:33 +0200 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: Would supporting ./john --help be a good idea? On 2012-07-05 21:19, Frank Dittrich wrote: > On 07/05/2012 09:08 PM, Frank Dittrich wrote: >> This needs to be changed: >> >> options.c:289: if (argc < 2) >> options.c-290- print_usage(name); >> >> And this as well: >> >> john.c:558: if (argc < 2) >> john.c-559- john_register_all(); /* for printing by opt_init() */ >> >> But I'd hate to make the same change in two different places. >> Would a new global variable be OK, a new parameter for opt_init(), or >> should I make john_register_all known in options.c, and call it inside >> print_usage()? > > Stupid me. > What's wrong with deleting those two lines from opt_init(), and adding > print_usage to john_init()? Try that, it sounds good but you never know what hits the fan. If it seems to work fine, it just might work fine :) magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.