Date: Thu, 05 Jul 2012 23:36:01 +0200 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: Silence -Wpointer-sign warnings in hmacSHA*_fmt_plug.c On 2012-07-05 20:26, Frank Dittrich wrote: > On 07/05/2012 08:11 PM, magnum wrote: >> This is in magnum-jumbo and downstream. Before Jim's alignment fix, it >> was signed: >> static char crypt_key[BINARY_SIZE+1]; >> >> Your patch is likely fine, but a better fix might be to declare the >> union member as signed. > > OK, I should have checked history. It's not for certain that this is better, I was just thinking out loud. But now that I get to choose, I like this much better. > Here's the other version of a possible fix. > Compiled with gcc and clang - warnings disappeared, no new warnings. > And it is also less code. > > Unfortunately, the file name is the same as in the first version, > because the subject has only be slightly changed at the end. I committed this now, thanks magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.