Date: Thu, 05 Jul 2012 20:11:22 +0200 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: Silence -Wpointer-sign warnings in hmacSHA*_fmt_plug.c On 2012-07-05 19:13, Frank Dittrich wrote: > With gcc 4.6.3, I get: > > hmacSHA512_fmt_plug.c:48:26: warning: pointer targets in initialization > differ in signedness [-Wpointer-sign] > ... > > As far as I remember, they didn't occur in jumbo-6. > Should those warnings just be silenced by something like this: > > -static char *crypt_key = u.c; // Requires alignment on generic sha2.c > +static char *crypt_key = (char *)u.c; // Requires alignment on generic > sha2.c > > > I think they can just be silenced, so here is a patch. This is in magnum-jumbo and downstream. Before Jim's alignment fix, it was signed: static char crypt_key[BINARY_SIZE+1]; Your patch is likely fine, but a better fix might be to declare the union member as signed. magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.