Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 30 Jun 2012 12:42:01 +0200
From: Tavis Ormandy <taviso@...xchg8b.com>
To: john-dev@...ts.openwall.com
Subject: Re: asan report

Dhiru Kholia <dhiru.kholia@...il.com> wrote:

> Hi,
> 
> So far, I have found out that asan doesn't work with the following
> formats:
> 

> 8. raw-sha1-ng
> 
> Benchmarking: Raw SHA-1 (pwlen <= 15) [128/128 SSE2 intrinsics 4x]...
> =================================================================
> ==30079== ERROR: AddressSanitizer global-buffer-overflow on address
> 0x0000006a9020 at pc 0x537f2e bp 0x7fff53cb89e0 sp 0x7fff53cb89d8 READ of
> size 16 at 0x0000006a9020 thread T0
>     #0 0x537f2e in sha1_fmt_set_key
> /home/dsk/magnum-jumbo/src/rawSHA1_ng_fmt.c:363
> 


It is complaining that I assume the key passed to set_key can be read with
one MOVDQU, I documented this in the comments. I would prefer not to change
this, because it is a very hot path.

In fact, I was going to suggest adding a flag that guarantees it will be
16-byte aligned so I can use MOVDQA.

Tavis.

-- 
-------------------------------------
taviso@...xchg8b.com | pgp encrypted mail preferred
-------------------------------------------------------

Powered by blists - more mailing lists

Your e-mail address:

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.