Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 28 Jun 2012 18:28:04 +0200
From: magnum <>
Subject: Re: KeePass patch for jumbo-6

On 2012-06-28 18:05, jfoug wrote:
>> From: magnum []
>> And don't forget to remove the fmt_default_get_source line from the
> struct!
> Would be nice to have a #define _JOHN_BLEEDING_ in the bleeding Makefile.
> That way, we can build formats such as:
> struct fmt_main {
>  ......
> #ifdef _JOHN_BLEEDING_
> 	fmt_default_get_source
> #endif
> };
> This would make 90% of the formats in jumbo and bleeding to be exactly the
> same.

True, but not much gain doing it now. But we must never use
JOHN_BLEEDING because bleeding is a moving target and what is currently
in bleeding will eventually be in magnum-jumbo (and in the end, a
release). We should have defined HAVE_GETSOURCE or something. Even more
canonical we should have defined some kind of FORMAT_STRUCT_VER when
prepare() was introduced already.


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.