Date: Thu, 28 Jun 2012 10:52:26 +0200 From: Tavis Ormandy <taviso@...xchg8b.com> To: john-dev@...ts.openwall.com Subject: Re: Re: Failed self test for raw-sha1-ng (linux-x86-sse2i OMP) Frank Dittrich <frank_dittrich@...mail.com> wrote: > On 06/28/2012 09:35 AM, Tavis Ormandy wrote: > > Frank Dittrich <frank_dittrich@...mail.com> > > wrote: > > > > > I just ran > >> > > > $ ./john --test=0|grep FAIL Benchmarking: Raw SHA-1 (pwlen <= 15) > > > [128/128 SSE2 intrinsics 4x]... FAILED (get_hash(0)) 1 out of 138 > > > tests have FAILED > >> > > > $ ./john --list=build-info Version: 1.7.9-jumbo-6-RC0 Build: > > > linux-x86-sse2i OMP Arch: 32-bit LE $JOHN is ./ Rec file version: REC3 > > > CHARSET_MIN: 32 (0x20) CHARSET_MAX: 126 (0x7e) CHARSET_LENGTH: 8 > > > Compiler version: 4.6.3 20120306 (Red Hat 4.6.3-2) gcc version: 4.6.3 > >> > > > This works: $ ./john --test=0 --format=raw-sha1-ng Warning: doing > > > quick benchmarking - the performance numbers will be inaccurate > > > Benchmarking: Raw SHA-1 (pwlen <= 15) [128/128 SSE2 intrinsics 4x]... > > > DONE Raw: 1331K c/s real, 1331K c/s virtual > >> > > > Frank > >> > > > > I see the bug, that's embarassing. Give me a minute to send a push > > request. > > First time I noticed that problem was on 21st of June: > http://openwall.com/lists/john-dev/2012/06/21/46 > > But at that raw-sha1 and raw-sha1-ng (or whatever the format label was at > that time) used the same format name "Raw SHA-1", so I wrongly assumed it > was raw-sha1 hat was broken. > > I could have been more careful at that time, then I would have noticed it > is not the original raw-sha1 that was broken. And I should have repeated > that test earlier. > > Hopefully your fix makes it into jumbo-6. Otherwise, Solar might release > jumbo-7 immediately afterwards. (I just read the jumbo-5 announcement > again and saw that john-1.7.9-jumbo-1- john-1.7.9-jumbo-4 existed for a > few hours only...) > > Frank > Pull request sent, FWIW, I had to ssh to another machine because it doesn't compile with gcc 3.4 which the machine I'm sitting at right now has, with this error: gcc -c -Wall -O2 -fomit-frame-pointer -I/usr/local/include -msse2 -DHAVE_CRYPT -DHAVE_DL -DUSING_ICC_S_FILE -funroll-loops keepass2john.c keepass2john.c:1: error: stray '\239' in program keepass2john.c:1: error: stray '\187' in program keepass2john.c:1: error: stray '\191' in program $ xxd keepass2john.c | head -1 0000000: efbb bf2f 2a20 6b65 6570 6173 7332 6a6f .../* keepass2jo Are those byteorder marks? Interesting that I can only remove them in vim with vim -b :-) I'll send a pull request for that as well, and a compilation fix for my code. Tavis. -- ------------------------------------- taviso@...xchg8b.com | pgp encrypted mail preferred -------------------------------------------------------
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.