Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 26 Jun 2012 16:55:52 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: john --list=build-version shows gcc version info even if built with clang

On Tue, Jun 26, 2012 at 09:49:32AM +0200, magnum wrote:
> $ clang -dM -E -x c /dev/null | fgrep '3.0'
> #define __VERSION__ "4.2.1 Compatible Ubuntu Clang 3.0 
> (tags/RELEASE_30/final)"
> #define __clang_version__ "3.0 (tags/RELEASE_30/final)"
> 
> We should use __clang_version__ if defined, and if not we can use 
> __GNUC__*. But before fixing this, the same should be determined for icc.

Why "before"?  I see no problem adding support for clang detection now
and for icc later.  Since you've already identified the macros above, I
think it's best to commit clang detection now, before jumbo-6.

Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.