Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 26 Jun 2012 09:37:58 +0200
From: magnum <>
Subject: Re: FMT_UNICODE and FMT_UTF8 flags

On 2012-06-26 07:21, Frank Dittrich wrote:
> On 06/26/2012 03:17 AM, magnum wrote:
>> On 2012-06-26 02:00, Solar Designer wrote:
>>> On Tue, Jun 26, 2012 at 01:32:58AM +0200, magnum wrote:
>>>> Formats that are UCS-2 internally
>>>> (like these) must set FMT_UNICODE and as long as they do not really
>>>> support encodings other than ISO-8859-1 they must not set FMT_UTF8.
>>> Is this documented anywhere?  The comments in formats.h don't make it
>>> clear that not setting these flags may have drastic consequences like
>>> what you describe.
>> I made the comments more clear now. They were probably from first
>> versions of the UTF-8 patch in 2009 and their meaning has skewed a
>> little (FMT_UTF8 should really be FMT_ENCODING nowadays).
> I adjusted the output of --list=format-all-details to the changes made
> by your commit f61def05, see attached patch.

Good idea, thanks.

> BTW: should that option be renamed to --list=all-format-details, even if
> just for easier bash completion?
> (all-format-details would be the only one starting with a, and this
> would leave us with just 2 names starting with f, not 3)

Let's keep it as-is.


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.