Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 25 Jun 2012 22:00:20 -0500
From: "jfoug" <>
To: <>
Subject: RE: md5cryptsse()'s uses of length[]

>From: Solar Designer []
>Jim -
>In sse-intrinsics.c: md5cryptsse(), there's a loop that assigns password
>lengths to length[i], then uses length[i] many times.  Wouldn't it be
>better to use an int variable local to that loop instead, and only at
>the end of each loop iteration store the value into length[i]?

Solar, that was not my code, so I am not sure of the reasons behind how it
was done.   But if this is the code that loads the null byte (or 1st byte?),
then yes, it probably should be some local int var.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.