Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [day] [month] [year] [list]
Date: Mon, 25 Jun 2012 11:31:42 +0200
From: Frank Dittrich <frank_dittrich@...mail.com>
To: john-dev@...ts.openwall.com
Subject: Fix clang make targets for the HAVE_NSS case (result: new compiler
 warning in mozilla_des.c)

So that uncommenting the HAVE_NSS definition really builds the mozilla
format.

This, however, generated a new warning:

mozilla_des.c:833:12: warning: comparison of unsigned expression < 0 is
always false [-Wtautological-compare]
        if (inLen < 0 || (inLen % 8) != 0 || maxOutLen < inLen || !cx ||
cx->direction != DES_ENCRYPT)
            ~~~~~ ^ ~
1 warning generated.


Format self test passes (tested on 32bit linux), but I think that
compiler warning should be fixed.

Frank

View attachment "0001-Fix-clang-make-targets-for-the-HAVE_NSS-case.patch" of type "text/x-patch" (2345 bytes)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.