john-dev - relbench: important bug fix for duplicate format names in file1

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Sun, 24 Jun 2012 22:24:24 +0200
From: Frank Dittrich <frank_dittrich@...mail.com>
To: john-dev@...ts.openwall.com
Subject: relbench: important bug fix for duplicate format names in file1

Thanks to Dhiru, my relbench changes are now on github.
Unfortunately, there's a small, but nasty bug included.

I should have tested my relbench changes  at least once using the same
input file as file1 and file2.

Here's a fix. Please apply.

Without this fix, for the first file the last benchmark of each format
would be counted (as was the case prior to my changes), whereas for the
second file the fastest one would be counted (which was the intended
logic for both files.

Now, it is always the fastest one that counts.

Please commit this change. Thanks in advance.

Frank

View attachment "0001-relbench-important-fix-for-duplicate-format-names-in.patch" of type "text/x-patch" (739 bytes)

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.