[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 22 Jun 2012 13:33:57 +0530
From: Dhiru Kholia <dhiru.kholia@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: Re: EPiServer format fails on 32-bit builds.
On Fri, Jun 22, 2012 at 12:34 PM, Frank Dittrich
<frank_dittrich@...mail.com> wrote:
> On 06/22/2012 07:57 AM, Dhiru Kholia wrote:
>> On Thu, Jun 21, 2012 at 9:38 PM, Dhiru Kholia <dhiru.kholia@...il.com> wrote:
>>> When I test the episerver format using the attached patch, I get
>>>
>>> ../run/john -format=episerver -t
>>> FAILED (get_hash[1](0))
>>
>> This bug is now hopefully fixed. Please pull and test. Thanks!
>
> OK, the test now passes.
> But a base64 encoded string of length 24 decodes to 24 / 4 * 3 = 18.
>
> So I wonder if you shouldn't use unsigned char esalt[18] instead of
> unsigned char esalt[16+1], and add an appropriate comment in the source
> code.
I didn't know this. I calculated 16+1 experimentally with following code
import base64
data = base64.decodestring("fGJ2wn/5WlzqQoDeCA2kXA==")
print len(data) # 16
18 is the upper bound. I will fix my source to use this upper bound.
Thanks for the tip.
--
Cheers,
Dhiru
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
