Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 19 Jun 2012 15:31:17 -0500
From: "jfoug" <>
To: <>
Subject: RE: wordlist dupe suppression

I will look into this.  Problem is there is a LOT of people working on the
code right there.  I hope my memory was correct on the statement I made.  I
did that code several years ago, and wrote that statement from memory, not
from finding the problem in code.

>From: Solar Designer []
>Jim -
>On Tue, Jun 19, 2012 at 01:12:06PM -0500, jfoug wrote:
>> I think the buggyness is likely an off by one in the initial
>> computation of line count.  I believe that if the file does not end in
>> \n, the line counts are correct. If it ends in a \n, then it is 1
>> larger.  This was a work around for a core if there was no trailing \n
>> line (IIRC).  The array of line pointers was not large enough.  I
>> thought the line count was corrected, after the true load (not the
>> line count check).  It looks like the line count check is being used
>> within this part of logging, and to determine if a dupe was found or
>Are you going to correct this?

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.