Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 19 Jun 2012 15:11:30 +0200
From: Tavis Ormandy <>
Subject: Re: [patch] optional new raw sha1 implemetation

On Tue, Jun 19, 2012 at 05:03:44PM +0400, Solar Designer wrote:
> > I noticed an easy way to fix it is just to check if get_hash() ==
> > binary_hash() first
> This sounds very wrong to me.  When get_hash() is worthwhile to use (as
> determined by the thresholds), John will use it instead of cmp_all() on
> its own - with no magic needed on your part.
> Perhaps there's some context to this that I am missing, though?

I don't think so, the performance impact is indeed very small, 0.1%
sounds right. Still, I want that 0.1% :-)


------------------------------------- | pgp encrypted mail preferred

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.