Date: Sun, 17 Jun 2012 13:10:17 +0400 From: "Elijah [W&P]" <smarteam.support@...il.com> To: john-dev@...ts.openwall.com Subject: Re: Add john.local.conf to release-Jumbo >clean: > $(RM) $(PROJ) $(PROJ_DOS) $(PROJ_WIN32) $(PROJ_WIN32_MINGW) so "make clean" the was removing the john.local.conf without remaking it when building "PROJ_WIN32" On 17 June 2012 12:57, magnum <john.magnum@...hmail.com> wrote: > Just what part of Makefile would delete the file? > BTW you don't have write access to the repo, please send a patch. > > magnum > > > On 2012-06-17 08:38, Elijah [W&P] wrote: > >> One thing - PROJ_WIN32 section in makefile has no "../run/john.local.conf" >> so file gets deleted on every "make clean" and not recreated while cygwin >> handles "touching" a file well. >> Tried to push a commit onto john-bleeding, not sure how it went, hoping >> for >> best :) >> >> On 11 June 2012 01:38, magnum<john.magnum@...hmail.**com<john.magnum@...hmail.com>> >> wrote: >> >> On 05/29/2012 10:22 PM, magnum wrote: >>> >>> I was thinking we might want to do one of these: >>>> >>>> Add an .include<john.local.conf> to the end of john.conf, and have the >>>> Makefile create an empty such file if it does not exist. Personally, I'd >>>> then add all my personal stuff in john.local.conf and the john.conf >>>> would be much easier to "sync" with the release version. >>>> >>>> Or alternatively: >>>> Add the same line to john.conf but also add a cludge in config.c so we >>>> never complain if that file does not exist. >>>> >>>> Or, perhaps: >>>> Do not even add that line to john.conf, but always source any >>>> john.local.conf file, if we found one. >>>> >>>> What do you think? >>>> >>>> >>> Excellent, I'll do as I please then. I went with the first option: When >>> building, john.local.conf will be created (empty) if it does not exist. >>> But >>> it will never be overwritten and no release tarball should ever contain >>> that file. >>> >>> Also, I committed some other changes I thought are undisputable: Create a >>> rules section "Extra" for the, until now, commented-out rules of Single >>> mode. Also, add new rules "Single-Extra" (consisting of Single plus >>> Extra) >>> and "Jumbo" (consisting of *all* rules we have, including NT). I wanted >>> to >>> preserve the name "All" for local use, that's why I used "Jumbo" instead. >>> >>> magnum >>> >>> >>> >> > > Content of type "text/html" skipped Download attachment "cygwin_makefile.diff" of type "application/octet-stream" (736 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.