[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120616233206.GG31349@cmpxchg8b.com>
Date: Sun, 17 Jun 2012 01:32:06 +0200
From: Tavis Ormandy <taviso@...xchg8b.com>
To: john-dev@...ts.openwall.com
Subject: Re: Re: [patch] optional new raw sha1 implemetation
On Sun, Jun 17, 2012 at 01:28:46AM +0200, magnum wrote:
> On 2012-06-17 01:25, Tavis Ormandy wrote:
> >Regarding switching memrchr to strrchr, I dont think this is correct,
> >they are strings on input, but I store them in a format that can be
> >converted to SHA-1 input very quickly and there is no guarantee there
> >is a nul byte at the end.
>
> Yes but we search for 0x80 and this *will* be present. I see no
> problem, and it works just fine.
>
> magnum
It searches *backwards* for 0x80, I think you might be thinking of
strchr.
Tavis.
--
-------------------------------------
taviso@...xchg8b.com | pgp encrypted mail preferred
-------------------------------------------------------
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
