Date: Thu, 7 Jun 2012 00:56:59 +0200 From: Frank Dittrich <frank_dittrich@...mail.com> To: john-dev@...ts.openwall.com Subject: Re: Do we need --list=formats? On 06/05/2012 09:53 AM, magnum wrote: > On 06/05/2012 09:21 AM, magnum wrote: >> On 06/05/2012 08:29 AM, Frank Dittrich wrote: >>> And in the next release we just get rid of --subformats? >> >> Yes. We could pull it from the usage blob immediately and drop the >> support later. We might add --list to the usage instead, with a >> description like: >> >> --list=WHAT List capabilities, see doc/OPTIONS or --list=? > > Done. BTW the bash completion doesn't seem to complete further than > --list= right now, I think it did earlier? The attached new version should fix this. I tested the´is version with official john 1.7.8, 1.7.9-jumbo-5, and with versions from your git repository prior and after --subformat=LIST has been deprecated. For current git (--subformat=LIST disappeared from usage output, --subformat=FORMAT included in --list=hidden-options), I use the stderr output from c3_fmt.c, converted to lower case, as possible completions for --subformat=*. john --test=0 --format=crypt --subformat=? 2>&1 | \ sed -n 's#,# #g;/^Subformat / s#^[^:]*:\(.*\)$#\L\1# p' So it should work even after changing c3_fmt.c, provided that the subformat list in the stderr output matches the list of valid subformats. Frank View attachment "john.bash_completion" of type "text/plain" (20692 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.