Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Wed, 6 Jun 2012 23:24:52 +0200
From: Frank Dittrich <>
Subject: ./john --test --format=crypt --subformat=BF (usage problem)

Hi magnum,

while testing my john.bash_completion changes, I noticed that in
c3_fmt.c the list of supported subformats written to stderr in case of a
wrong subformat doesn't match what is really tested in init().

$ ./john --test --format=crypt --subformat=BF
Subformat unknown to John. Currently supported: DES, MD5, BF, SHA-256,

The subformats actually allowed are
bf or bcrypt or blowfish
sha256 or sha-256
sha512 or sha-512

Maybe the error message should use lower case subformat names as well,
or init should use strcasecmp, to allow upper case subformat names, or both.

I would make listing and checking subformat names similar to format
names. Than means, now that the list of formats in the usage output is
written in lower case, I would use lower case subformats in the stderr
output. I'd also allow using upper case subformat names, since
--format=DES also works.
I wouldn't list all the different ways to specify a particular
subformat, just listing bf instead of bf, bcrypt and blowfish is OK.
Sould we also use raw-sha256 and raw-sha512 as subformat names instead,
to match the format names?

What do you think?


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.