Date: Tue, 29 May 2012 12:09:45 -0700 (PDT) From: deepika dutta <deepikadutta_19@...oo.com> To: "john-dev@...ts.openwall.com" <john-dev@...ts.openwall.com> Subject: Re: mschap-v2 conversion I have updated the patch with changes (except SSE). It now builds for openmp. I have tested on my system, everything works fine. But you should also test for correctness. The patch is attached. Cheers, Deepika ________________________________ From: deepika dutta <deepikadutta_19@...oo.com> To: "john-dev@...ts.openwall.com" <john-dev@...ts.openwall.com> Sent: Monday, May 28, 2012 11:23 AM Subject: [john-dev] mschap-v2 conversion >OK, that seems to work. But as long as it breaks the normal builds, I can't commit it. Could you try to get it work for at least linux-x86-sse2? yaa I have to do it and I want to take it up. Since I am new to SSE programming, I don't exactly know how to work with it but I will try (ofcourse with your help :) ) >Speeds before: >Benchmarking: MSCHAPv2 C/R MD4 DES [mschapv2]... DONE >Many salts: 2304K c/s real, 2317K c/s virtual >Only one salt: 1638K c/s real, 1638K c/s virtual >After: >Benchmarking: MSCHAPv2 C/R MD4 DES [mschapv2]... DONE >Many salts: 4861K c/s real, 4861K c/s virtual >Only one salt: 2466K c/s real, 2466K c/s virtual good, the changes seems to work :) >I think you should change ALGORITHM_NAME to reflect that we are using BS. Maybe you could just use DES_BS_ALGORITHM_NAME? Ok I will do it. >BTW, I get these warnings: >MSCHAPv2_fmt_plug.c: In function ‘generate_output’: >MSCHAPv2_fmt_plug.c:269:10: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] >MSCHAPv2_fmt_plug.c: In function ‘mschapv2_set_salt’: >MSCHAPv2_fmt_plug.c:425:15: warning: unused variable ‘temp’ [-Wunused-variable] They are due to signed variables and unused temp variable in the code, i will handle them. >A more serious problem is that you break OMP builds even for generic: yaa I actually didn't do it. Just wanted to make everything work for simplest case but I will do it now. Cheers, Deepika Content of type "text/html" skipped Download attachment "john-1.7.9-jumbo5-openmp.diff" of type "application/octet-stream" (14413 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.