Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 11 May 2012 00:46:46 +0200
From: magnum <>
Subject: Re: Fwd: bash auto-completion for john

On 05/10/2012 09:42 PM, magnum wrote:
> On 05/09/2012 01:15 AM, magnum wrote:
>> Maybe I'll get time to have a look at this soon-ish. So at a minimum we
>> need the following:
>> --list=incremental
>> --list=ext-modes  (external w/ generate)
>> --list=rules
>> --list=filters	(external w/o generate)
> Here's a beta. This implements --list=[inc-modes|rules|externals] but
> does not yet tell filters from ext-modes.

I committed a first version to git now. It's now:


--list=externals will list all and any externals.
--list=ext-modes will list external modes that has generate().

--list=ext-filters will list external modes that has filter()
*including* ones that also has generate(). This suits bash completion.
For other uses (like JtR GUI) we might need another option later, eg.
--list=ext-filters-only that lists external modes that has filter() but
*not* generate().

Solar, I had to do this in compiler.c:

diff --git a/src/compiler.c b/src/compiler.c
index 96f8ecd..464a8f3 100644
--- a/src/compiler.c
+++ b/src/compiler.c
@@ -940,7 +940,9 @@ void c_execute_fast(void *addr)
                int op = 0;

-               assert(c_op_return != &&op_return); /* Don't do this
twice */
+               /* Needed for -list option */
+               if (c_op_return == &&op_return) return;
+               //assert(c_op_return != &&op_return); /* Don't do this
twice */

                c_op_return = &&op_return;
                c_op_bz = &&op_bz;

It seems OK here, but I thought you need to have a look at it cause I
don't really understand what's happening. BTW, for licensing these
patches, I'm still waiting for a standard text for licensing
contributions to Openwall with right to sublicense.

Now, I look forward to some more bash completion magic from Frank! This
will be very comfortable.



Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.