Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 25 Mar 2012 19:49:37 +0530
From: Dhiru Kholia <dhiru.kholia@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: [JtR patch] Fast cracker for Mozilla Firefox,
 Thunderbird and SeaMonkey master passwords.

On Sun, Mar 25, 2012 at 3:29 PM, magnum <john.magnum@...hmail.com> wrote:
> On 03/25/2012 01:50 AM, Solar Designer wrote:
>> On Sat, Mar 24, 2012 at 01:12:53PM +0100, magnum wrote:
>>> On 03/24/2012 10:25 AM, Dhiru Kholia wrote:
>>>> However, I am getting the following warnings during compilation from
>>>> the DES code. Can someone take a look and fix them? Thanks!
>>>>
>>>> mozilla_des.c: In function ?DES_CBCEn?:
>>>> mozilla_des.c:751:2: warning: dereferencing type-punned pointer will
>>>> break strict-aliasing rules [-Wstrict-aliasing]
>>>
>>> This is more of a follow-up question than an answer :)
>>>
>>> The enclosed patch mutes the warnings. Why are the braces needed and
>>> what are they "doing"? The format seem to work fine with this patch.
>>
>> How did you arrive at the braces?  This is weird stuff.  I am not even
>> sure how to parse it (would need to do actual testing to see how gcc
>> treats it) - I think this may be either an array initializer or GCC's
>> "Statement Exprs" extension (although then you'd probably be required to
>> include a semicolon before the closing curly brace, so this is probably
>> not it).
>
> I saw braces used like that in an example somewhere. I have no idea what
> they do, hence my question :)

I ran "indent -kr -i8 -nlp -nbbo -l120 -lc120" on mozilla_des.c,
leading to generation of those braces. heh, didn't knew that indent
could change the source so dramatically. I am reverting the source
back to original.

-- 
Cheers,
Dhiru

Powered by blists - more mailing lists

Your e-mail address:

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.